Skip to content

fix(instrumentation-net): Don't operate on closed span #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 3 commits into from
Nov 27, 2023
Merged

fix(instrumentation-net): Don't operate on closed span #1819

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3415c2d
fix(instrumentation-net): Don't operate on closed span
mhennoch Nov 23, 2023
c7a93f2
Fix lint
mhennoch Nov 23, 2023
b6d9991
Merge branch 'main' into fix-1775
mhennoch Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(instrumentation-net): Don't operate on closed span
  • Loading branch information
@mhennoch
mhennoch committed Nov 23, 2023
commit 3415c2d6a310c4449c02ac1de6fd22dc61d20bd0
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-net/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class NetInstrumentation extends InstrumentationBase<Net> {
}
};

for (const event of [SocketEvent.CLOSE, SocketEvent.ERROR]) {
for (const event of [SocketEvent.CLOSE, SocketEvent.ERROR, SocketEvent.SECURE_CONNECT]) {
socket.once(event, otelTlsRemoveListeners);
}

Expand Down