feat(host-metrics)!: use the package name as the default instrumentation scope name, to align with instrumentations #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on scope name, to align with instrumentations Closes: open-telemetry#1782
…ntrib repo requirements on changelog entries
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 144 144
Lines 7388 7388
Branches 1474 1474
=======================================
Hits 6760 6760
Misses 628 628
|
hectorhdzg
reviewed
Nov 27, 2023
| } | ||
|
|
||
| const DEFAULT_NAME = 'opentelemetry-host-metrics'; | ||
| const DEFAULT_NAME = '@opentelemetry/host-metrics'; |
Member
There was a problem hiding this comment.
This could be potentially a breaking change if someone is already relying on this, we should mention that in the changelog
Contributor
Author
There was a problem hiding this comment.
IIUC the changelog will automatically get this PR title added to it for the next release. However,
- that doesn't include the explicit strings, so won't be as helpful as possible.
- Do you think I should add the bang (
feat(host-metrics)!: ...) so that this gets added to the "breaking change" section and triggers a new major version (0.34.0)?
Member
There was a problem hiding this comment.
Yeah, I think 0.34.0 should be used for next release.
Contributor
Author
There was a problem hiding this comment.
I've updated the PR title to add the !. I hope that is sufficient -- i.e. that the PR title and not the original comment message title is used.
trentm
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1782
@pichlermarc I wasn't sure if this should count as a feature or a fix. You had put the "enhancement" label on the issue, so I used "feat" in the commit/PR title.
Update: As pointed out below this change could be a breaking change if one relied on the
instrumentationScope.namevalue.