[mysql] implement semantic conventions#183
Merged
obecny merged 2 commits intoopen-telemetry:masterfrom Sep 8, 2020
Merged
Conversation
dyladan
requested changes
Aug 26, 2020
markwolff
approved these changes
Aug 28, 2020
markwolff
reviewed
Aug 28, 2020
dyladan
approved these changes
Aug 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 96.18% 95.21% -0.97%
==========================================
Files 81 92 +11
Lines 4167 4724 +557
Branches 423 488 +65
==========================================
+ Hits 4008 4498 +490
- Misses 159 226 +67
|
vmarchaud
approved these changes
Sep 1, 2020
obecny
reviewed
Sep 1, 2020
ef95cf0 to
8fdcd0d
Compare
0eae530 to
2c6e983
Compare
Signed-off-by: Naseem <naseem@transit.app>
fc45ff0 to
b3e29eb
Compare
obecny
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
partially #116
Short description of the changes
Using the semantic-conventions package and following specification. A function
getDbStatementwas extracted for building the statement by formatting sql with values.