Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: apply common config handling in setConfig
  • Loading branch information
blumamir committed Apr 30, 2024
commit eb388d89a4ac5ebd6bf7d1cdaedf4e871721e246
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class DataloaderInstrumentation extends InstrumentationBase {
return this._config;
}

override setConfig(config: DataloaderInstrumentationConfig) {
override setConfig(config: DataloaderInstrumentationConfig = {}) {
this._config = config;
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-undici/src/undici.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export class UndiciInstrumentation extends InstrumentationBase {
this.subscribeToChannel('undici:request:error', this.onError.bind(this));
}

override setConfig(config?: UndiciInstrumentationConfig): void {
override setConfig(config: UndiciInstrumentationConfig = {}): void {
super.setConfig(config);

if (config?.enabled) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class BunyanInstrumentation extends InstrumentationBase {
return this._config;
}

override setConfig(config: BunyanInstrumentationConfig) {
override setConfig(config: BunyanInstrumentationConfig = {}) {
this._config = Object.assign({}, DEFAULT_CONFIG, config);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export class PinoInstrumentation extends InstrumentationBase {
return this._config;
}

override setConfig(config: PinoInstrumentationConfig) {
override setConfig(config: PinoInstrumentationConfig = {}) {
this._config = config;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class WinstonInstrumentation extends InstrumentationBase {
return this._config;
}

override setConfig(config: WinstonInstrumentationConfig) {
override setConfig(config: WinstonInstrumentationConfig = {}) {
this._config = config;
}

Expand Down