chore: refactoring host metrics, aligning with semantic conventions#266
Merged
obecny merged 7 commits intoopen-telemetry:masterfrom Dec 11, 2020
Merged
chore: refactoring host metrics, aligning with semantic conventions#266obecny merged 7 commits intoopen-telemetry:masterfrom
obecny merged 7 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 95.07% 94.94% -0.13%
==========================================
Files 110 110
Lines 5888 5937 +49
Branches 609 617 +8
==========================================
+ Hits 5598 5637 +39
- Misses 290 300 +10
|
vmarchaud
approved these changes
Nov 22, 2020
Member
There was a problem hiding this comment.
lgtm, quick question though: in the doc you state that it collect CPU, Memory, Heap, Network, Event Loop, Garbage Collector, Heap Space but i dont see any code to retrieve event loop nor GC / Heap space metrics, i guess there will comes later on ?
EDIT: Linter need to be fixed before merge
Member
Author
fixed |
dyladan
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring host metrics