fix(koa): End span and record exception on a middleware exception#281
Merged
vmarchaud merged 3 commits intoopen-telemetry:masterfrom Jan 18, 2021
Merged
fix(koa): End span and record exception on a middleware exception#281vmarchaud merged 3 commits intoopen-telemetry:masterfrom
vmarchaud merged 3 commits intoopen-telemetry:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 95.39% 95.41% +0.01%
==========================================
Files 115 115
Lines 6061 6087 +26
Branches 591 592 +1
==========================================
+ Hits 5782 5808 +26
Misses 279 279
|
03c1076 to
578a2af
Compare
obecny
approved these changes
Dec 29, 2020
vmarchaud
approved these changes
Jan 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279
Not sure why the lint task failed, I did run
npm run lint:fixprior to comitting.Which problem is this PR solving?
This PR fixes the problem where
.end()is never called on the span for a middleware layer when the middleware layer throws an exception / rejects a promise.The master branch fails on the test case that I added.
Short description of the changes
span.end()for the span that's created for a middleware layer. Also record the exception in the span (as an event), then rethrow it so the application can handle it.I considered using the
safeExecuteInTheMiddleutility function, but it doesn't look like it works well with async functions.