Support OpenTelemetry SDK 0.8.x#30
Merged
dyladan merged 10 commits intoopen-telemetry:masterfrom May 29, 2020
Merged
Conversation
dyladan
requested review from
OlivierAlbertini,
bg451,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
mayurkale22
approved these changes
May 13, 2020
Member
|
Would be nice if you can update examples too. |
|
Hi all, a polite bump on this PR? I'm unable to use the latest otel releases as propagator jaeger is still pinned on context-base v0.6.x Let me know if I can help out at all. |
Member
Author
|
I am going to update this today as we just actually released 0.8.1. It will be released probably tomorrow or wednesday. Is that ok? |
|
That's perfect, no rush. Thank you! |
|
Hey @dyladan I noticed 0.8.2 was released. Just wanted to ping a reminder here, just in case it got lost in the shuffle. Best, Justin |
Member
Author
|
Sorry @justinwalz I'll get to this tomorrow hopefully. |
markwolff
approved these changes
May 28, 2020
Member
Author
|
@markwolff any idea why pg is failing again here? edit: nevermind I found it c04ed24 |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 94.32% 94.32% -0.01%
==========================================
Files 57 57
Lines 3295 3294 -1
Branches 351 351
==========================================
- Hits 3108 3107 -1
Misses 187 187
|
vmarchaud
approved these changes
May 29, 2020
dyladan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.