Skip to content

feat: add instrumentation-dns #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flarna merged 19 commits into from
Feb 9, 2021
Merged

feat: add instrumentation-dns #302

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c39e595
feat: add instrumentation-dns
Flarna Jan 12, 2021
5cdd843
remove setConfig
Flarna Jan 14, 2021
f476771
Merge remote-tracking branch 'upstream/master' into instrumentation-dns
Flarna Jan 14, 2021
f012486
Merge branch 'master' into instrumentation-dns
Flarna Jan 15, 2021
640fe05
chore: review findings
Flarna Jan 18, 2021
9e5ee04
Merge branch 'master' into instrumentation-dns
Flarna Jan 18, 2021
35946ba
Merge branch 'master' into instrumentation-dns
Flarna Jan 21, 2021
1989590
chore: move to otel 0.15.0
Flarna Jan 21, 2021
0e4221e
Merge remote-tracking branch 'upstream/master' into instrumentation-dns
Flarna Jan 22, 2021
53ffef1
Merge branch 'main' into instrumentation-dns
Flarna Jan 27, 2021
ae2df64
chore: update version
Flarna Jan 27, 2021
f4ab56f
(chore) correct links to point to main
Flarna Jan 28, 2021
6867b48
chore: correct repo
Flarna Jan 28, 2021
1135b50
Merge branch 'main' into instrumentation-dns
Flarna Jan 29, 2021
af40098
Merge branch 'main' into instrumentation-dns
Flarna Feb 1, 2021
a13faea
Merge remote-tracking branch 'upstream/main' into instrumentation-dns
Flarna Feb 1, 2021
8f981f7
chore: move to 0.13.0
Flarna Feb 1, 2021
df1cdd9
Merge branch 'main' into instrumentation-dns
Flarna Feb 2, 2021
77c5087
Merge branch 'main' into instrumentation-dns
Flarna Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove setConfig
  • Loading branch information
@Flarna
Flarna committed Jan 14, 2021
commit 5cdd84353d2f6a54925b30a9a06cdebe3b2b23d5
7 changes: 0 additions & 7 deletions plugins/node/opentelemetry-instrumentation-dns/src/dns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { LookupAddress } from 'dns';
import { Span, SpanKind, SpanOptions } from '@opentelemetry/api';
import {
InstrumentationBase,
InstrumentationConfig,
InstrumentationNodeModuleDefinition,
isWrapped,
} from '@opentelemetry/instrumentation';
Expand All @@ -43,12 +42,6 @@ export class DnsInstrumentation extends InstrumentationBase<Dns> {
super('@opentelemetry/instrumentation-dns', VERSION, _config);
}

public setConfig(
config: DnsInstrumentationConfig & InstrumentationConfig = {}
) {
this._config = Object.assign({}, config);
}

init(): InstrumentationNodeModuleDefinition<Dns>[] {
return [
new InstrumentationNodeModuleDefinition<Dns>(
Expand Down