feat(instrumentation-ioredis): add requireParentSpan option to config#372
Merged
naseemkullah merged 4 commits intoopen-telemetry:mainfrom Mar 4, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 12 12
Lines 409 409
Branches 44 44
=======================================
Hits 384 384
Misses 25 25 |
vmarchaud
approved these changes
Mar 3, 2021
naseemkullah
reviewed
Mar 3, 2021
plugins/node/opentelemetry-instrumentation-ioredis/src/utils.ts
Outdated
Show resolved
Hide resolved
naseemkullah
approved these changes
Mar 3, 2021
obecny
reviewed
Mar 3, 2021
plugins/node/opentelemetry-instrumentation-ioredis/src/utils.ts
Outdated
Show resolved
Hide resolved
added 2 commits
March 4, 2021 11:16
naseemkullah
approved these changes
Mar 4, 2021
obecny
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
requiredParentbehavior with other plugins which have different defaults.requiredParentSpan, as suggested by @obecny .Short description of the changes
requiredParentSpanto instrumentation config, and skip instrumentation only if this config option was set tofalse.