feat: mysql instrumentation#393
Merged
dyladan merged 7 commits intoopen-telemetry:mainfrom Mar 23, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 10 10
Lines 407 407
Branches 44 44
=======================================
Hits 384 384
Misses 23 23 |
vmarchaud
reviewed
Mar 22, 2021
vmarchaud
approved these changes
Mar 22, 2021
Flarna
approved these changes
Mar 22, 2021
Member
|
don't merge yet there are more broken links |
Member
You mean in the PR ? I don't see any Also @dyladan i can't rebase your PR so you'll need to do it |
Member
Ignore it, I posted it in wrong PR :/ |
obecny
reviewed
Mar 23, 2021
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
can you uncomment mysql in meta package ?
Member
Author
done |
obecny
reviewed
Mar 23, 2021
obecny
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains no functionality changes aside from what it took to do the conversion and pass tests.