Skip to content

chore: fixing context propagation on mongo callback#403

Merged
vmarchaud merged 6 commits intoopen-telemetry:mainfrom
obecny:mongodb
Apr 9, 2021
Merged

chore: fixing context propagation on mongo callback#403
vmarchaud merged 6 commits intoopen-telemetry:mainfrom
obecny:mongodb

Conversation

@obecny
Copy link
Member

@obecny obecny commented Mar 31, 2021

Which problem is this PR solving?

Short description of the changes

  • when using callback instead of promise mongodb is using tick when calling callback. This causing the context to be not propagated correctly

@obecny obecny added the bug Something isn't working label Mar 31, 2021
@obecny obecny self-assigned this Mar 31, 2021
@obecny obecny requested a review from a team March 31, 2021 17:37
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #403 (1a6389d) into main (55fa0e9) will decrease coverage by 0.21%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   94.43%   94.21%   -0.22%     
==========================================
  Files          11       12       +1     
  Lines         431      432       +1     
  Branches       48       48              
==========================================
  Hits          407      407              
- Misses         24       25       +1     
Impacted Files Coverage Δ
...apackages/auto-instrumentations-web/src/version.ts 0.00% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <100.00%> (ø)

@vmarchaud
Copy link
Member

cc @jtmalinowski i believe your comments were addressed, are you okay to merge it ?

@vmarchaud vmarchaud merged commit 3a0dd0d into open-telemetry:main Apr 9, 2021
@obecny obecny deleted the mongodb branch April 9, 2021 10:01
obecny added a commit to obecny/opentelemetry-js-contrib that referenced this pull request Apr 15, 2021
Co-authored-by: Valentin Marchaud <thisismac47@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mongodb instrumentation: nested span is not generated when using callback

4 participants