Skip to content

document: fix express example #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 4 commits into from
Apr 7, 2021
Merged

document: fix express example #413

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f8b470
fix: reference SpanStatusCode correctly
rauno56 Apr 5, 2021
0cc26ed
refactor: correct the usecase for async
rauno56 Apr 5, 2021
81cc5fb
feat: update loading http and express instrumentations
rauno56 Apr 6, 2021
2444d21
docs: update the readme for `instrumentation-express`
rauno56 Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: reference SpanStatusCode correctly
  • Loading branch information
@rauno56
rauno56 committed Apr 6, 2021
commit 0f8b470452fd0a8677334418dd5e220932ee0a0e
7 changes: 4 additions & 3 deletions examples/express/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ function makeRequest() {
api.context.with(api.setSpan(api.ROOT_CONTEXT, span), async () => {
try {
const res = await axios.get('http://localhost:8080/run_test');
span.setStatus({ code: api.StatusCode.OK });
console.log(res.statusText);
console.log('status:', res.statusText);
span.setStatus({ code: api.SpanStatusCode.OK });
} catch (e) {
span.setStatus({ code: api.StatusCode.ERROR, message: e.message });
console.log('failed:', e.message);
span.setStatus({ code: api.SpanStatusCode.ERROR, message: e.message });
}
span.end();
console.log('Sleeping 5 seconds before shutdown to ensure all records are flushed.');
Expand Down