docs: Explicitly state that express instrumentation does not export spans without http instrumentation#472
Merged
vmarchaud merged 2 commits intoopen-telemetry:mainfrom May 5, 2021
Merged
Conversation
…pans without http instrumentation As discussed in the meeting today, I think making this point clear helps enduser to understand what they _might_ be doing wrong if no spans are exported.
vmarchaud
approved these changes
May 5, 2021
naseemkullah
approved these changes
May 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #472 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 133 133
Lines 8254 8254
Branches 810 810
=======================================
Hits 7862 7862
Misses 392 392 |
dyladan
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the meeting today, I think making this point clear helps enduser to understand what they might be doing wrong if no spans are exported.