Skip to content

feat(instrumentation-document-load): performance paint timing events #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obecny merged 7 commits into from
Jun 8, 2021
Merged

feat(instrumentation-document-load): performance paint timing events #484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b38ed0
feat(instrumentation-document-load): performance paint timing events
kkruk-sumo Apr 26, 2021
23efca5
Merge remote-tracking branch 'upstream/main' into first_paint_metric
kkruk-sumo May 18, 2021
6c4c31c
Merge branch 'main' into first_paint_metric
kkruk-sumo May 19, 2021
33ac031
Merge branch 'main' into first_paint_metric
kkruk-sumo May 24, 2021
4cc06db
chore: fixed lint
kkruk-sumo May 24, 2021
c481e8b
Merge branch 'main' into first_paint_metric
kkruk-sumo May 26, 2021
367b039
Merge branch 'main' into first_paint_metric
kkruk-sumo Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fixed lint
  • Loading branch information
@kkruk-sumo
kkruk-sumo committed May 24, 2021
commit 4cc06db8131f9c74f544e660400af5629870d7de
6 changes: 3 additions & 3 deletions plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ export class DocumentLoadInstrumentation extends InstrumentationBase<unknown> {
* @param rootSpan
*/
private _addResourcesSpans(rootSpan: Span): void {
const resources: PerformanceResourceTiming[] = ((otperformance as unknown) as Performance).getEntriesByType?.(
'resource'
) as PerformanceResourceTiming[];
const resources: PerformanceResourceTiming[] = (
otperformance as unknown as Performance
).getEntriesByType?.('resource') as PerformanceResourceTiming[];
if (resources) {
resources.forEach(resource => {
this._initResourceSpan(resource, rootSpan);
Expand Down
12 changes: 6 additions & 6 deletions plugins/web/opentelemetry-instrumentation-document-load/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ import { EventNames } from './enums/EventNames';

export const getPerformanceNavigationEntries = (): PerformanceEntries => {
const entries: PerformanceEntries = {};
const performanceNavigationTiming = ((otperformance as unknown) as Performance).getEntriesByType?.(
'navigation'
)[0] as PerformanceEntries;
const performanceNavigationTiming = (
otperformance as unknown as Performance
).getEntriesByType?.('navigation')[0] as PerformanceEntries;

if (performanceNavigationTiming) {
const keys = Object.values(PTN);
Expand Down Expand Up @@ -66,9 +66,9 @@ const performancePaintNames = {
};

export const addSpanPerformancePaintEvents = (span: Span) => {
const performancePaintTiming = ((otperformance as unknown) as Performance).getEntriesByType?.(
'paint'
);
const performancePaintTiming = (
otperformance as unknown as Performance
).getEntriesByType?.('paint');
if (performancePaintTiming) {
performancePaintTiming.forEach(({ name, startTime }) => {
if (hasKey(performancePaintNames, name)) {
Expand Down