Skip to content

fix: dns plugin remove hostname attribute #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 8 commits into from
Jun 1, 2021
Merged

fix: dns plugin remove hostname attribute #488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79b14ba
fix: replace net.peer.name with dns.hostname in dns plugin
svrnm May 18, 2021
2886679
fix: run lint fix
svrnm May 18, 2021
f5cccd2
fix: remove import for semantic conventions from assertSpan.ts
svrnm May 18, 2021
8a573cb
Merge branch 'main' into dns-fix-hostname-attribute
svrnm May 19, 2021
b5bac58
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
svrnm May 26, 2021
c34e7f5
Merge branch 'dns-fix-hostname-attribute' of github.com:svrnm/opentel…
svrnm May 26, 2021
0203d9d
fix: remove dns hostname
svrnm May 26, 2021
bc7361d
Merge branch 'main' into dns-fix-hostname-attribute
svrnm Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: replace net.peer.name with dns.hostname in dns plugin
  • Loading branch information
@svrnm
svrnm committed May 18, 2021
commit 79b14ba10db2064790f274e9621b29073cc57b89
1 change: 1 addition & 0 deletions plugins/node/opentelemetry-instrumentation-dns/src/enums/AttributeNames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ export enum AttributeNames {
DNS_ERROR_CODE = 'dns.error_code',
DNS_ERROR_NAME = 'dns.error_name',
DNS_ERROR_MESSAGE = 'dns.error_message',
DNS_HOSTNAME = 'dns.hostname'
}
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-dns/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import { LookupAddress } from 'dns';
import { diag, Span, SpanKind } from '@opentelemetry/api';
import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
import {
InstrumentationBase,
InstrumentationNodeModuleDefinition,
Expand All @@ -33,6 +32,7 @@ import {
} from './types';
import * as utils from './utils';
import { VERSION } from './version';
import { AttributeNames } from './enums/AttributeNames';

/**
* Dns instrumentation for Opentelemetry
Expand Down Expand Up @@ -114,7 +114,7 @@ export class DnsInstrumentation extends InstrumentationBase<Dns> {
const span = plugin.tracer.startSpan(name, {
kind: SpanKind.CLIENT,
attributes: {
[SemanticAttributes.NET_PEER_NAME]: hostname,
[AttributeNames.DNS_HOSTNAME]: hostname,
},
});

Expand Down
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-dns/test/utils/assertSpan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const assertSpan = (
span.status.message
);
assert.strictEqual(
span.attributes[SemanticAttributes.NET_PEER_NAME],
span.attributes[AttributeNames.DNS_HOSTNAME],
validations.hostname
);

Expand Down