You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is pretty much the same as opentelemetry-instrumentation-mysql2, but I simplified it by only wrapping Connection.prototype. This exact code might actually work for mysql as well.
We don't have a good precedent of 2-package instrumentation - I mainly don't want to start that discussion here.
To answer your question: Because those do not match between the two packages. Not saying it's not doable, it absolutely is with unions and whatnot, but transforming the code to work with mysql2 was already a task and I don't see a good reason to push more into a PR.
FYI we have both http (that handle https too) and grpc (that handle grpc-js and grpc c++) that have this behavior and we don't have any issue with it.
I totally think that since you already written as a separate package it doesnt matter but i was more asking if you tried and there was issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds autoinstrumentation for
mysql2.Short description of the changes
This is pretty much the same as
opentelemetry-instrumentation-mysql2, but I simplified it by only wrappingConnection.prototype. This exact code might actually work formysqlas well.