Skip to content

feat: postgresql responseHook support #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmarchaud merged 7 commits into from
Jun 28, 2021
Merged

feat: postgresql responseHook support #528

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f8cdb0
feat: postgresql responseHook support
nata7che Jun 9, 2021
137f925
Merge branch 'main' into main
nata7che Jun 15, 2021
e7914ff
Merge branch 'main' into main
nata7che Jun 20, 2021
022f0f7
Merge branch 'main' into main
nata7che Jun 22, 2021
5f071f3
CR comments
nata7che Jun 23, 2021
0a6952a
Merge branch 'main' into main
nata7che Jun 24, 2021
38b78c6
CR comments
nata7che Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CR comments
  • Loading branch information
@nata7che
nata7che committed Jun 24, 2021
commit 38b78c6a007790444fe37e5be3e4b8c08a06911c
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-pg/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export function handleExecutionResult(
span: Span,
pgResult: pgTypes.QueryResult | pgTypes.QueryArrayResult | unknown
) {
if (config.responseHook !== undefined && pgResult !== undefined) {
if (typeof config.responseHook === 'function') {
safeExecuteInTheMiddle(
() => {
config.responseHook!(span, {
Expand Down