feat: move aws/gcp detectors from opentelemetry-js repo#593
Merged
obecny merged 9 commits intoopen-telemetry:mainfrom Aug 4, 2021
Merged
feat: move aws/gcp detectors from opentelemetry-js repo#593obecny merged 9 commits intoopen-telemetry:mainfrom
obecny merged 9 commits intoopen-telemetry:mainfrom
Conversation
13a6580 to
1ad1fdf
Compare
1ad1fdf to
51d748a
Compare
Codecov Report
@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 94.78% 94.94% +0.15%
==========================================
Files 179 195 +16
Lines 10976 11630 +654
Branches 1088 1115 +27
==========================================
+ Hits 10404 11042 +638
- Misses 572 588 +16
|
Flarna
reviewed
Jul 28, 2021
detectors/node/opentelemetry-resource-detector-gcp/package.json
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jul 28, 2021
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jul 28, 2021
Flarna
suggested changes
Jul 28, 2021
Member
Flarna
left a comment
There was a problem hiding this comment.
Just minor nits.
But i set it to need work to block merging until contrib 0.24.0 is out as these packages have been released already via core repo in version 0.24.0
Flarna
reviewed
Jul 28, 2021
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/opentelemetry-test-utils/package.json
Member
Author
|
@Flarna thanks for reviews. Updated, PTAL again :) |
Flarna
approved these changes
Jul 30, 2021
detectors/node/opentelemetry-resource-detector-aws/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de>
rauno56
approved these changes
Aug 3, 2021
Member
|
This also requires a companion-PR to remove the code from |
Member
|
is there an easy way to make diff this vs open-telemetry/opentelemetry-js#2392 ? |
Member
Author
|
@obecny suppose we have those two repo in a root directory, and opentelemetry-js is on main branch, we can use |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes open-telemetry/opentelemetry-js#1689
Short description of the changes