Replace 55681 endpoint with 4318 endpoint for HTTP collector#603
Merged
vmarchaud merged 3 commits intoopen-telemetry:mainfrom Jan 24, 2022
Merged
Replace 55681 endpoint with 4318 endpoint for HTTP collector#603vmarchaud merged 3 commits intoopen-telemetry:mainfrom
vmarchaud merged 3 commits intoopen-telemetry:mainfrom
Conversation
b9ab870 to
4330faf
Compare
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 95.29% 94.71% -0.59%
==========================================
Files 10 16 +6
Lines 701 813 +112
Branches 142 162 +20
==========================================
+ Hits 668 770 +102
- Misses 33 43 +10
|
blumamir
reviewed
Aug 6, 2021
obecny
previously requested changes
Aug 6, 2021
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Member
|
PR in core repo: open-telemetry/opentelemetry-js#2557 |
Member
|
@NathanielRN , now that the change is merged in core repo, can you please solve the conflicts and upgrade the collector image so we can merge this PR? |
2130d88 to
edde512
Compare
edde512 to
107ff7e
Compare
vmarchaud
approved these changes
Jan 23, 2022
blumamir
reviewed
Jan 23, 2022
blumamir
approved these changes
Jan 24, 2022
dyladan
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Follow up to core repo PR here: open-telemetry/opentelemetry-js#2395
The specifications just updated the HTTP port to be
4318in this PR: open-telemetry/opentelemetry-specification#1839Likewise, the Collector also updated from
55681to4318open-telemetry/opentelemetry-collector#3743, but will support both for some time.Short description of the changes
4318