chore(mysql2): adding TAV script#641
Merged
dyladan merged 8 commits intoopen-telemetry:mainfrom Aug 30, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
- Coverage 96.68% 95.18% -1.51%
==========================================
Files 13 67 +54
Lines 634 4588 +3954
Branches 124 427 +303
==========================================
+ Hits 613 4367 +3754
- Misses 21 221 +200
|
Member
Author
|
I'm putting this PR in draft mode, I found some issues for |
added 6 commits
August 30, 2021 11:13
Member
Author
|
After fixing broken tests for older versions (v2.0.0, v2.0.1, v2.0.2, v2.1.0) |
dyladan
approved these changes
Aug 30, 2021
Member
|
Might be worth making the fixes in a separate |
Member
Author
The fix is relevant only for the tests, it doesn't change the instrumentation code. |
rauno56
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This will let us run
test-all-versionsscripts formysql2plugin, and make sure tests are green for all versions supported by the instrumentations.Currently this is just a script in package.json which can be run manually on demand by user to verify compatibility. This is not integrated into CI or expected to impact project in any way.