Skip to content

Commit e91cac5

Browse files
mhassan1vmarchaud
andauthored
fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies (#3283)
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
1 parent 6b8bb15 commit e91cac5

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

experimental/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ All notable changes to experimental packages in this project will be documented
1212

1313
### :bug: (Bug Fix)
1414

15+
* fix(node-sdk): move `@opentelemetry/semantic-conventions` to `dependencies` [#3283](https://github.com/open-telemetry/opentelemetry-js/pull/3283) @mhassan1
16+
1517
### :books: (Refine Doc)
1618

1719
* docs(metrics-exporters): fix wrong exporter const name in example [#3270](https://github.com/open-telemetry/opentelemetry-js/issues/3270) @pichlermarc

experimental/packages/opentelemetry-sdk-node/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,15 @@
5555
"@opentelemetry/resources": "1.7.0",
5656
"@opentelemetry/sdk-metrics": "0.33.0",
5757
"@opentelemetry/sdk-trace-base": "1.7.0",
58-
"@opentelemetry/sdk-trace-node": "1.7.0"
58+
"@opentelemetry/sdk-trace-node": "1.7.0",
59+
"@opentelemetry/semantic-conventions": "1.7.0"
5960
},
6061
"peerDependencies": {
6162
"@opentelemetry/api": ">=1.0.0 <1.3.0"
6263
},
6364
"devDependencies": {
6465
"@opentelemetry/api": ">=1.0.0 <1.3.0",
6566
"@opentelemetry/context-async-hooks": "1.7.0",
66-
"@opentelemetry/semantic-conventions": "1.7.0",
6767
"@types/mocha": "9.1.1",
6868
"@types/node": "18.6.5",
6969
"@types/semver": "7.3.9",

0 commit comments

Comments
 (0)