fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies#3283
Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom Sep 30, 2022
mhassan1:sdk-node-semantic-conventions-dep
Merged
fix(node-sdk): move @opentelemetry/semantic-conventions to dependencies#3283pichlermarc merged 2 commits intoopen-telemetry:mainfrom mhassan1:sdk-node-semantic-conventions-dep
@opentelemetry/semantic-conventions to dependencies#3283pichlermarc merged 2 commits intoopen-telemetry:mainfrom
mhassan1:sdk-node-semantic-conventions-dep
Conversation
Flarna
approved these changes
Sep 28, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
- Coverage 93.44% 93.43% -0.02%
==========================================
Files 241 241
Lines 7249 7249
Branches 1507 1507
==========================================
- Hits 6774 6773 -1
- Misses 475 476 +1
|
legendecas
approved these changes
Sep 29, 2022
pichlermarc
approved these changes
Sep 29, 2022
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Thank you for fixing this 🙂
vmarchaud
approved these changes
Sep 29, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3282.
Short description of the changes
This PR moves
@opentelemetry/semantic-conventionsfromdevDependenciestodependenciesin@opentelemetry/sdk-node.Type of change
How Has This Been Tested?
N/A
Checklist: