Skip to content

Make Labels Optional for CounterMetric::add #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayurkale22 merged 12 commits into from
May 13, 2020
Merged

Make Labels Optional for CounterMetric::add #1032

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2cb9dae
Make labels optional for add
astorm May 7, 2020
abf279c
updating interfaces, and MeasureMetric
astorm May 7, 2020
0c4c82b
lint
astorm May 7, 2020
276fedf
for a metri defined with label keys, but without metric values
astorm May 7, 2020
fb000c1
whatever you say lint
astorm May 7, 2020
9928ba7
Merge branch 'master' into astorm/labels-optional
astorm May 8, 2020
15a1cf7
reverting "getValues" changes
astorm May 8, 2020
649a4b8
Merge branch 'master' into astorm/labels-optional
astorm May 8, 2020
d12dbda
Merge branch 'master' into astorm/labels-optional
astorm May 12, 2020
38cb3a9
adding shoulder, fixing param
astorm May 13, 2020
ffd2593
Merge branch 'master' into astorm/labels-optional
astorm May 13, 2020
daa44cd
Merge branch 'master' into astorm/labels-optional
dyladan May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@astorm
astorm committed May 7, 2020
commit 0c4c82b8a0f599548eca57b4b8b9e6a037af4045
6 changes: 3 additions & 3 deletions packages/opentelemetry-metrics/test/Meter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ describe('Meter', () => {
disabled: false,
monotonic: true,
});
counter.add(1)
meter.collect()
counter.add(1);
meter.collect();
const [record1] = meter.getBatcher().checkPointSet();
assert.strictEqual(record1.aggregator.toPoint().value, 1);
})
});

it('should return counter with resource', () => {
const counter = meter.createCounter('name') as CounterMetric;
Expand Down