docs(batcher): document how to configure custom aggregators #989#1100
Merged
mayurkale22 merged 3 commits intoopen-telemetry:masterfrom May 28, 2020
Merged
docs(batcher): document how to configure custom aggregators #989#1100mayurkale22 merged 3 commits intoopen-telemetry:masterfrom
mayurkale22 merged 3 commits intoopen-telemetry:masterfrom
Conversation
vmarchaud
requested review from
OlivierAlbertini,
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
obecny and
rochdev
as code owners
vmarchaud
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 115 115
Lines 3407 3407
Branches 686 686
=======================================
Hits 3147 3147
Misses 260 260 |
mayurkale22
reviewed
May 25, 2020
Member
mayurkale22
left a comment
mayurkale22
left a comment
There was a problem hiding this comment.
Added a few minor comments, otherwise LGTM
vmarchaud
force-pushed
the
document-batcher-api
branch
from
75f5fbb to
2921c87
Compare
dyladan
approved these changes
May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we got a specific folder where we document how to extend the SDK to customise its behavior so i've wrote it inside the
docthe folder, happy to move it if you think this is more of an example !closes #989