feat: add the UpDownCounter instrument#1120
Merged
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom Jun 12, 2020
Merged
feat: add the UpDownCounter instrument#1120mayurkale22 merged 6 commits intoopen-telemetry:masterfrom
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 92.39% 92.33% -0.06%
==========================================
Files 118 119 +1
Lines 3407 3433 +26
Branches 694 696 +2
==========================================
+ Hits 3148 3170 +22
- Misses 259 263 +4
|
dyladan
approved these changes
Jun 3, 2020
obecny
reviewed
Jun 4, 2020
markwolff
reviewed
Jun 4, 2020
markwolff
approved these changes
Jun 5, 2020
1e29d9d to
8f73840
Compare
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Added new API endpoint and default SDK implementation.
The
CounterandSumObserverinstruments are defined as monotonic (by default) andUpDown-variations of these two instruments are non-monotonic. So no need to havemonotonicflag separately.Updated Prometheus export to export
UpDownCounterasGaugetype.I will take care of examples and remaining documentation in subsequent PR.