Skip to content

feat(opentelemetry-js): infer zipkin service name from resource #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayurkale22 merged 9 commits into from
Jun 6, 2020
Merged

feat(opentelemetry-js): infer zipkin service name from resource #1138

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c113d7
feat(opentelemetry-js): infer zipkin service name from resource
rezakrimi Jun 3, 2020
e0dd742
Update packages/opentelemetry-exporter-zipkin/src/zipkin.ts
rezakrimi Jun 3, 2020
1ce71b9
fix: making serviceName optional for zipkin config
rezakrimi Jun 3, 2020
c0b56d3
fix: resolving type issues
rezakrimi Jun 3, 2020
42de702
Update packages/opentelemetry-exporter-zipkin/src/zipkin.ts
rezakrimi Jun 3, 2020
ad18c21
refactor: making default service name a constant
rezakrimi Jun 4, 2020
c7cf118
Merge branch 'zipkin-service-name' of https://github.com/rezakrimi/op…
rezakrimi Jun 4, 2020
edcc5f9
Merge branch 'master' into zipkin-service-name
mayurkale22 Jun 5, 2020
bfc8566
Merge branch 'master' into zipkin-service-name
mayurkale22 Jun 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/opentelemetry-exporter-zipkin/src/zipkin.ts 
making service name optional for zipkin exporter

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
  • Loading branch information
@rezakrimi @dyladan
rezakrimi and dyladan authored Jun 3, 2020
commit e0dd7425bad29e48d51c6c4f120c9dd9909e355d
2 changes: 1 addition & 1 deletion packages/opentelemetry-exporter-zipkin/src/zipkin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class ZipkinExporter implements SpanExporter {
private readonly _statusCodeTagName: string;
private readonly _statusDescriptionTagName: string;
private readonly _reqOpts: http.RequestOptions;
private _serviceName: string;
private _serviceName?: string;
private _isShutdown: boolean;

constructor(config: zipkinTypes.ExporterConfig) {
Expand Down