chore(todo): add missing span sampling test#1151
Merged
mayurkale22 merged 4 commits intoopen-telemetry:masterfrom Jun 9, 2020
Merged
chore(todo): add missing span sampling test#1151mayurkale22 merged 4 commits intoopen-telemetry:masterfrom
mayurkale22 merged 4 commits intoopen-telemetry:masterfrom
Conversation
markwolff
requested review from
OlivierAlbertini,
bg451,
dyladan,
mayurkale22,
mwear,
naseemkullah,
obecny,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 116 116
Lines 3395 3395
Branches 688 688
=======================================
Hits 3134 3134
Misses 261 261 |
naseemkullah
approved these changes
Jun 9, 2020
mayurkale22
approved these changes
Jun 9, 2020
vmarchaud
approved these changes
Jun 9, 2020
obecny
approved these changes
Jun 9, 2020
dyladan
reviewed
Jun 9, 2020
dyladan
approved these changes
Jun 9, 2020
dyladan
added
the
Merge:LGTM
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…lemetry#1151) * Add tests to validate that requireParentSpan applies to connect * Copy finishedSpans * Implement requireParentSpan for connect Co-authored-by: Amir Blum <amir@aspecto.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of the changes