fix: default url for otelcol#1254
Merged
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom Jun 29, 2020
jufab:default-url-otelcol
Merged
fix: default url for otelcol#1254mayurkale22 merged 6 commits intoopen-telemetry:masterfrom jufab:default-url-otelcol
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom
jufab:default-url-otelcol
Conversation
jufab
requested review from
OlivierAlbertini,
bg451,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
rochdev and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1254 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 126 126
Lines 3597 3597
Branches 724 724
=======================================
Hits 3356 3356
Misses 241 241 |
vmarchaud
approved these changes
Jun 28, 2020
mayurkale22
approved these changes
Jun 29, 2020
naseemkullah
approved these changes
Jun 29, 2020
obecny
reviewed
Jun 29, 2020
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
please update also examples/collector-exporter-node
dyladan
approved these changes
Jun 29, 2020
Member
|
This is good to go, please resolve the conflicts. |
obecny
approved these changes
Jun 29, 2020
Member
|
Welcome to OpenTelemetry community and congrats for first contribution. |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes