feat(opentelemetry-web): capture decodedBodySize / http.response_content_length#1262
Merged
dyladan merged 11 commits intoopen-telemetry:masterfrom Jul 6, 2020
johnbley:master
Merged
feat(opentelemetry-web): capture decodedBodySize / http.response_content_length#1262dyladan merged 11 commits intoopen-telemetry:masterfrom johnbley:master
dyladan merged 11 commits intoopen-telemetry:masterfrom
johnbley:master
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 92.86% 93.09% +0.22%
==========================================
Files 126 133 +7
Lines 3364 3764 +400
Branches 688 761 +73
==========================================
+ Hits 3124 3504 +380
- Misses 240 260 +20
|
obecny
reviewed
Jul 1, 2020
Member
obecny
left a comment
There was a problem hiding this comment.
My my concern is naming.
With regards to the size itself there are also decodedBodySize and encodedBodySize. Having that in mind should we create another issue to add those too deciding about suitable name from
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#common-attributes
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-plugin-fetch/src/enums/AttributeNames.ts
Outdated
Show resolved
Hide resolved
obecny
reviewed
Jul 3, 2020
vmarchaud
approved these changes
Jul 4, 2020
dyladan
reviewed
Jul 6, 2020
dyladan
approved these changes
Jul 6, 2020
markwolff
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Capture
encodedBodySizefrom PerformanceResourceTiming (when available); report ashttp.response_content_length.