Removing default span attributes by aravinsiva · Pull Request #1342 · open-telemetry/opentelemetry-js

aravinsiva · 2020-07-23T02:02:07Z

Removing default span attributes as per:

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

codecov · 2020-07-23T02:06:18Z

Codecov Report

Merging #1342 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   93.45%   93.45%   -0.01%     
==========================================
  Files         148      148              
  Lines        4128     4127       -1     
  Branches      835      836       +1     
==========================================
- Hits         3858     3857       -1     
  Misses        270      270

Impacted Files	Coverage Δ
packages/opentelemetry-tracing/src/config.ts	`100.00% <ø> (ø)`
packages/opentelemetry-tracing/src/Tracer.ts	`100.00% <100.00%> (ø)`

dyladan · 2020-07-23T14:36:43Z

You still need to remove it from the tracer itself

…m tracer object Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

aravinsiva · 2020-07-23T15:40:36Z

You still need to remove it from the tracer itself

Just removed it.

packages/opentelemetry-tracing/test/BasicTracerProvider.test.ts

package.json

packages/opentelemetry-tracing/src/Tracer.ts

…uggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

mayurkale22

Most of open suggestions are small - going to provide LGTM and hope you can address prior to merging.

dyladan · 2020-07-27T16:37:59Z

@open-telemetry/javascript-approvers please review

* upstream/master: fix: add missing grpc-js index (open-telemetry#1358) chore: 0.10.0 release proposal (open-telemetry#1345) Proto update to latest to support arrays and maps (open-telemetry#1339) feat: add OTEL_LOG_LEVEL env var (open-telemetry#974) Add nodejs sdk package (open-telemetry#1187) feat: add baggage support to the opentracing shim (open-telemetry#918) Removing default span attributes (open-telemetry#1342)

* refactor(opentelemetry-tracing): removing default span attributes Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing default span attributed from tracer object Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing accidental add to package.json Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* feat: graceful shutdown for tracing and metrics * fix: wording in test case * fix: typo * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: add callbacks to shutdown methods * fix: merge conflict * simplify meter shutdown code Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: fix one-liner * private function name style fix Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: naming of private member variables * fix: graceful shutdown now works in browser * fix: window event listener will trigger once * fix: modify global shutdown helper functions * fix: remove callback from remove listener args * fix: change global shutdown function names and simplify functionality * fix: add rest of function refactoring and simplification * fix: remove unintended code snippet * fix: refactor naming of listener cleanup function and fix sandbox issue * fix: make global shutdown cleanup local * fix: change interval of MeterProvider collection to ensure it does not trigger through clock * chore: removing _cleanupGlobalShutdownListeners * fix: remove unnecesary trace provider member function * Removing default span attributes (#1342) * refactor(opentelemetry-tracing): removing default span attributes Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing default span attributed from tracer object Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing accidental add to package.json Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * feat: add baggage support to the opentracing shim (#918) Co-authored-by: Mayur Kale <mayurkale@google.com> * Add nodejs sdk package (#1187) Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: legendecas <legendecas@gmail.com> Co-authored-by: Mark Wolff <mrw00010@gmail.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> * feat: add OTEL_LOG_LEVEL env var (#974) * Proto update to latest to support arrays and maps (#1339) * chore: 0.10.0 release proposal (#1345) * fix: add missing grpc-js index (#1358) * chore: 0.10.1 release proposal (#1359) * feat(api/context-base): change compile target to es5 (#1368) * Feat: Make ID generator configurable (#1331) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: require grpc-js instead of grpc in grpc-js example (#1364) Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com> * chore(deps): update all non-major dependencies (#1371) * chore: bump metapackage dependencies (#1383) * chore: 0.10.2 proposal (#1382) * fix: remove unnecesary trace provider member function * refactor(metrics): distinguish different aggregator types (#1325) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * Propagate b3 parentspanid and debug flag (#1346) * feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * feat: Collector Metric Exporter for the Web (#1308) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * Fix issues in TypeScript getting started example code (#1374) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * chore: deploy canary releases (#1384) * fix: protos pull * fix: address marius' feedback * chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier * fix: add documentation and cleanup code * fix: remove async label from shutdown and cleanup test case * fix: update controller collect to return promise * fix: make downsides of disabling graceful shutdown more apparent Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com> Co-authored-by: Aravin <34178459+aravinsiva@users.noreply.github.com> Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com> Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: legendecas <legendecas@gmail.com> Co-authored-by: Mark Wolff <mrw00010@gmail.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Naseem <naseem@transit.app> Co-authored-by: Mark Wolff <mark.wolff@microsoft.com> Co-authored-by: Cong Zou <32532612+EdZou@users.noreply.github.com> Co-authored-by: Reginald McDonald <40721169+reggiemcdonald@users.noreply.github.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: srjames90 <srjames@lightstep.com> Co-authored-by: David W <dwitt12345@gmail.com> Co-authored-by: Mick Dekkers <mickdekkersnl@gmail.com>

…metry#1342) * fix(instrumentation-net): make tls span parent of net span * chore: lint fix

refactor(opentelemetry-tracing): removing default span attributes

e87205b

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

aravinsiva requested review from OlivierAlbertini, dyladan, legendecas, markwolff, mayurkale22, mwear, naseemkullah, obecny and vmarchaud as code owners July 23, 2020 02:02

aravinsiva added 2 commits July 23, 2020 11:16

refactor(opentelemetry-tracing): removing default span attributed fro…

4fa26af

…m tracer object Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

refactor(opentelemetry-tracing): removing accidental add to package.json

8a7934e

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

sjbrunst reviewed Jul 23, 2020

View reviewed changes

dyladan reviewed Jul 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

packages/opentelemetry-tracing/src/Tracer.ts Outdated Show resolved Hide resolved

aravinsiva and others added 2 commits July 23, 2020 12:55

refactor(opentelemetry-tracing): removing redundant test and fixing s…

57e02a4

…uggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

Merge branch 'master' into removing_default_attributes

b6791e1

mayurkale22 approved these changes Jul 23, 2020

View reviewed changes

aravinsiva changed the title ~~Removing default span attributes [WIP]~~ Removing default span attributes Jul 23, 2020

sjbrunst approved these changes Jul 23, 2020

View reviewed changes

dyladan approved these changes Jul 23, 2020

View reviewed changes

aravinsiva added 3 commits July 24, 2020 09:28

Merge branch 'master' into removing_default_attributes

0f611a4

Merge branch 'master' into removing_default_attributes

eac8499

Merge branch 'master' into removing_default_attributes

a442f53

naseemkullah approved these changes Jul 27, 2020

View reviewed changes

obecny approved these changes Jul 27, 2020

View reviewed changes

obecny merged commit 1ec5991 into open-telemetry:master Jul 27, 2020

mayurkale22 mentioned this pull request Jul 27, 2020

Remove Default Span Configuration #1341

Closed

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023

fix(instrumentation-net): make tls span parent of net span (open-tele…

1ee197e

…metry#1342) * fix(instrumentation-net): make tls span parent of net span * chore: lint fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing default span attributes#1342

Removing default span attributes#1342
obecny merged 8 commits intoopen-telemetry:masterfrom
aravinsiva:removing_default_attributes

aravinsiva commented Jul 23, 2020

Uh oh!

codecov bot commented Jul 23, 2020 •

edited

Loading

Uh oh!

dyladan commented Jul 23, 2020

Uh oh!

aravinsiva commented Jul 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mayurkale22 left a comment

Uh oh!

dyladan commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

aravinsiva commented Jul 23, 2020

Uh oh!

codecov bot commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dyladan commented Jul 23, 2020

Uh oh!

aravinsiva commented Jul 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mayurkale22 left a comment

Choose a reason for hiding this comment

Uh oh!

dyladan commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jul 23, 2020 •

edited

Loading