chore!: refer to resource labels as attributes#1419
chore!: refer to resource labels as attributes#1419dyladan merged 5 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 145 145
Lines 4335 4335
Branches 883 883
=======================================
Hits 4080 4080
Misses 255 255
|
|
/cc @markwolff since your new packages will need to incorporate these changes |
|
confirm. I'll resolve the conflicts |
| try { | ||
| const labelString = process.env.OTEL_RESOURCE_LABELS; | ||
| if (!labelString) { | ||
| const rawAttributes = process.env.OTEL_RESOURCE_ATTRIBUTES; |
There was a problem hiding this comment.
I'm wondering one thing here, above all should this be a part of environment instead of accessing process.env directly. I know this under platform node, but still I would be in favour of getting env variables through getEnv(), I'm fine to do it in next PR as it was already like this before, WDYT ?
There was a problem hiding this comment.
I agree, but I think it is outside the scope of this PR.
|
Conventional Commits requires that a ! be appended to the commit type or a footer |
Which problem is this PR solving?
Short description of the changes