fix: ignore TIMERWRAP in AsyncHooksContextManager#1530
Merged
dyladan merged 3 commits intoopen-telemetry:masterfrom Sep 21, 2020
Merged
fix: ignore TIMERWRAP in AsyncHooksContextManager#1530dyladan merged 3 commits intoopen-telemetry:masterfrom
dyladan merged 3 commits intoopen-telemetry:masterfrom
Conversation
TIMERWRAP is used internally in node.js up to version 11 to combine timeouts with the same timeout value. This combination can lead to false context propagation. Every timer additionally creates a Timeout resource therefore TIMERWRAP is not needed for correct propagation and it's safe to ignore it in context manager.
Flarna
requested review from
OlivierAlbertini,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 154 154
Lines 4762 4763 +1
Branches 951 952 +1
=======================================
+ Hits 4468 4469 +1
Misses 294 294
|
dyladan
approved these changes
Sep 14, 2020
vmarchaud
approved these changes
Sep 15, 2020
obecny
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes: #1494
Short description of the changes
TIMERWRAPis used internally in node.js up to version 11 to combine timeouts with the same timeout value. This combination can lead to false context propagation.Every timer additionally creates a
Timeoutresource thereforeTIMERWRAPis not needed for correct propagation and it's safe to ignore it in context manager.Refs: nodejs/node#20894