chore: variable names cleanup#1536
Merged
dyladan merged 4 commits intoopen-telemetry:masterfrom Sep 22, 2020
Merged
Conversation
Variable names in the trace example were not fully clear. This meant that the relationships between different operations also was unclear. Have amended.
DarkPurple141
requested review from
OlivierAlbertini,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 155 155
Lines 4811 4811
Branches 971 971
=======================================
Hits 4480 4480
Misses 331 331 |
mayurkale22
approved these changes
Sep 21, 2020
Member
mayurkale22
left a comment
mayurkale22
left a comment
There was a problem hiding this comment.
Lgtm, thanks for the change
markwolff
approved these changes
Sep 21, 2020
dyladan
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Found this example to be slightly confusing.
Short description of the changes
Variable names in the trace example were not fully clear. This meant that the relationships between different operations also was unclear. Have amended accordingly.