Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(exporter-prometheus): add appendTimestamp option to ExporterConfig
Signed-off-by: Antonio Franco <antoniomrfranco@gmail.com>
  • Loading branch information
antoniomrfranco committed Nov 24, 2020
commit 835cd7374c6801a070c9c3fc0f822a17474d0343
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@ export class PrometheusExporter implements MetricExporter {
port: 9464,
endpoint: '/metrics',
prefix: '',
appendTimestamp: true,
};

private readonly _logger: api.Logger;
private readonly _port: number;
private readonly _endpoint: string;
private readonly _server: Server;
private readonly _prefix?: string;
private readonly _appendTimestamp?: boolean;
private _serializer: PrometheusSerializer;
private _batcher = new PrometheusLabelsBatcher();

Expand All @@ -56,8 +58,9 @@ export class PrometheusExporter implements MetricExporter {
this._logger = config.logger || new NoopLogger();
this._port = config.port || PrometheusExporter.DEFAULT_OPTIONS.port;
this._prefix = config.prefix || PrometheusExporter.DEFAULT_OPTIONS.prefix;
this._appendTimestamp = config.appendTimestamp ?? PrometheusExporter.DEFAULT_OPTIONS.appendTimestamp;
this._server = createServer(this._requestHandler);
this._serializer = new PrometheusSerializer(this._prefix);
this._serializer = new PrometheusSerializer(this._prefix, this._appendTimestamp);

this._endpoint = (
config.endpoint || PrometheusExporter.DEFAULT_OPTIONS.endpoint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ export interface ExporterConfig {
* */
prefix?: string;

/**
* Append timestamp to metrics
* @default true
*/
appendTimestamp?: boolean;

/**
* Endpoint the metrics should be exposed at with preceding slash
* @default '/metrics'
Expand Down