refactor: batch observer to be independent from metric types #1709
+95
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
OlivierAlbertini,
dyladan,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
legendecas
force-pushed
the
feat/batch-observer
branch
from
bf8ec5c to
01d2034
Compare
- BatchObservers do not have to be created with names - BatchObservers do not have instruments for their own
legendecas
force-pushed
the
feat/batch-observer
branch
from
01d2034 to
4ccaed5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
+ Coverage 92.13% 92.15% +0.02%
==========================================
Files 166 166
Lines 5591 5573 -18
Branches 1194 1194
==========================================
- Hits 5151 5136 -15
+ Misses 440 437 -3
|
vmarchaud
approved these changes
Dec 2, 2020
Member
vmarchaud
left a comment
vmarchaud
left a comment
There was a problem hiding this comment.
lgtm, just need to fix the build
dyladan
approved these changes
Dec 2, 2020
obecny
reviewed
Dec 2, 2020
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
Nice change, please fix the return type, have some concerns with regards to new BatchObserver which still uses the old interface for its options, shouldn't this be changed too ?
# Conflicts: # packages/opentelemetry-api/src/metrics/Meter.ts # packages/opentelemetry-metrics/src/BatchObserver.ts # packages/opentelemetry-metrics/src/Meter.ts
7 tasks
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…lemetry#1709) * refactor: batch observer to be independent from metric types - BatchObservers do not have to be created with names - BatchObservers do not have instruments for their own * fixup: nodejs v8 compatibilities * fixup: replace all batch observer metric occurrences with batch observer
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…lemetry#1709) * refactor: batch observer to be independent from metric types - BatchObservers do not have to be created with names - BatchObservers do not have instruments for their own * fixup: nodejs v8 compatibilities * fixup: replace all batch observer metric occurrences with batch observer
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes