Skip to content

fix(exporter-collector): all http export requests should share same a… #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naseemkullah merged 6 commits into from
Jan 25, 2021
Merged

fix(exporter-collector): all http export requests should share same a… #1863

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd40b7a
fix(exporter-collector): all http export requests should share same a…
blumamir Jan 24, 2021
fd704c8
fix(exporter-collector): no log warning on agent options with default…
blumamir Jan 24, 2021
9a74974
Merge branch 'master' into collector-exporter-agent
blumamir Jan 24, 2021
5419312
fix(collector-exporter): add excpetion message to logger when agent c…
blumamir Jan 24, 2021
eca81a4
chore: fix typo in test
blumamir Jan 24, 2021
f57a562
style(exporter-collector): object spread undefined
blumamir Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style(exporter-collector): object spread undefined
  • Loading branch information
@blumamir
blumamir committed Jan 24, 2021
commit f57a5621743e90406ed81d323e1931a71a6a7897
3 changes: 1 addition & 2 deletions packages/opentelemetry-exporter-collector/src/platform/node/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,8 @@ export function createHttpAgent(

try {
const parsedUrl = new url.URL(config.url as string);
const httpAgentOptions = config.httpAgentOptions ?? {};
const Agent = parsedUrl.protocol === 'http:' ? http.Agent : https.Agent;
return new Agent({ keepAlive: true, ...httpAgentOptions });
return new Agent({ keepAlive: true, ...config.httpAgentOptions });
} catch (err) {
logger.error(
`collector exporter failed to create http agent. err: ${err.message}`
Expand Down