chore: remove all gitter links and replace with dicussions#1866
Merged
dyladan merged 4 commits intoopen-telemetry:mainfrom Jan 27, 2021
Merged
chore: remove all gitter links and replace with dicussions#1866dyladan merged 4 commits intoopen-telemetry:mainfrom
dyladan merged 4 commits intoopen-telemetry:mainfrom
Conversation
dyladan
requested review from
Flarna,
OlivierAlbertini,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Flarna
approved these changes
Jan 25, 2021
vmarchaud
approved these changes
Jan 25, 2021
Codecov Report
@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
- Coverage 92.66% 92.65% -0.02%
==========================================
Files 174 174
Lines 6030 6030
Branches 1278 1278
==========================================
- Hits 5588 5587 -1
- Misses 442 443 +1
|
obecny
reviewed
Jan 25, 2021
johnbley
approved these changes
Jan 26, 2021
Member
johnbley
left a comment
johnbley
left a comment
There was a problem hiding this comment.
Nice! I grepped and noticed that you missed a reference in CONTRIBUTING.md:
you can ask for a review on Gitter channel
obecny
approved these changes
Jan 26, 2021
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…metry#1866) * chore: remove all gitter links and replace with dicussions * chore: remove reference to gitter in contributing.md
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…metry#1866) * chore: remove all gitter links and replace with dicussions * chore: remove reference to gitter in contributing.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have switched from gitter to discussions, I would like to encourage users to ask questions there.