Skip to content

chore: lint on shadowing in non-test sources, fix a few of them #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmarchaud merged 5 commits into from
Feb 20, 2021
Merged

chore: lint on shadowing in non-test sources, fix a few of them #1922

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4bbae0
chore: lint on shadowing in non-test sources, fix a few of them
johnbley Feb 10, 2021
ec20102
chore: better names in Meter.ts
johnbley Feb 11, 2021
959ca0b
Merge branch 'main' into main
dyladan Feb 16, 2021
27aa146
Merge branch 'main' into main
johnbley Feb 18, 2021
0b4bd3a
Merge branch 'main' into main
vmarchaud Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into main
  • Loading branch information
@johnbley
johnbley authored Feb 18, 2021
commit 27aa1460c8b0e521c3267bba50509eb21df51816
2 changes: 1 addition & 1 deletion packages/opentelemetry-exporter-collector/src/platform/node/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function sendWithHttp<ExportItem, ServiceRequest>(
res.on('data', chunk => (responseData += chunk));
res.on('end', () => {
if (res.statusCode && res.statusCode < 299) {
collector.logger.debug(`statusCode: ${res.statusCode}`, responseData);
diag.debug(`statusCode: ${res.statusCode}`, responseData);
onSuccess();
} else {
const error = new collectorTypes.CollectorExporterError(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.