Skip to content

fix(propagator-jaeger): zero pad extracted trace id to 32 characters #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 1 commit into from
Apr 7, 2021
Merged

fix(propagator-jaeger): zero pad extracted trace id to 32 characters #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(propagator-jaeger): zero pad extracted trace id to 32 characters 
fixes #1983
  • Loading branch information
@sid-maddy
sid-maddy committed Apr 5, 2021
commit ce54776102e38201eedc2d34ac62c6709204a588
4 changes: 3 additions & 1 deletion packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ function deserializeSpanContext(serializedString: string): SpanContext | null {
if (headers.length !== 4) {
return null;
}
const [traceId, spanId, , flags] = headers;

const [_traceId, spanId, , flags] = headers;

const traceId = _traceId.padStart(32, '0');
const traceFlags = flags.match(/^[0-9a-f]{2}$/i) ? parseInt(flags) & 1 : 1;

return { traceId, spanId, isRemote: true, traceFlags };
Expand Down
4 changes: 2 additions & 2 deletions packages/opentelemetry-propagator-jaeger/test/JaegerHttpTracePropagator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('JaegerHttpTracePropagator', () => {

assert.deepStrictEqual(extractedSpanContext, {
spanId: '45fd2a9709dadcf1',
traceId: '9c41e35aeb6d1272',
traceId: '00000000000000009c41e35aeb6d1272',
isRemote: true,
traceFlags: TraceFlags.SAMPLED,
});
Expand All @@ -132,7 +132,7 @@ describe('JaegerHttpTracePropagator', () => {

assert.deepStrictEqual(extractedSpanContext, {
spanId: '5ac292c4a11a163e',
traceId: 'ac1f3dc3c2c0b06e',
traceId: '0000000000000000ac1f3dc3c2c0b06e',
isRemote: true,
traceFlags: TraceFlags.SAMPLED,
});
Expand Down