Skip to content

feat: add semconv generator for semantic-conventions-package #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmarchaud merged 17 commits into from
Apr 10, 2021
Merged

feat: add semconv generator for semantic-conventions-package #2083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c131413
feat: add semconv generator for `semantic-conventions`-package
tapico-weyert Apr 8, 2021
4724305
feat: update `semantic-conventations`-package by generating using new…
tapico-weyert Apr 8, 2021
310d124
fix: update packages to use the new `SemanticAttribute`-class
tapico-weyert Apr 8, 2021
5b40934
fix: improve the `semconv`-template to better match eslint prettier r…
tapico-weyert Apr 8, 2021
3e9f64e
chore: run `lint:fix`-task after generating source files
tapico-weyert Apr 8, 2021
3302972
chore: move argument to its own line in `generate.sh`
tapico-weyert Apr 8, 2021
9b889ef
fix: ensure we generate against v1.1.0 of the spec
tapico-weyert Apr 8, 2021
55d2c9b
fix: removed the out of spec semantic conventions from package
tapico-weyert Apr 8, 2021
3ff5b47
chore: merge branch 'main' into chore-otel-add-semconv-generator
tapico-weyert Apr 8, 2021
a8b4115
style: ran `npm run lint:fix` on the code base
tapico-weyert Apr 8, 2021
c2fb34a
fix: use `RPC_GRPC_STATUS_CODE` from `semantic-convention` that a cus…
tapico-weyert Apr 8, 2021
4b16cff
test: fix Span test to ensure attribute value is a string
tapico-weyert Apr 8, 2021
79c9720
chore: merge branch 'upstream-main' into chore-otel-add-semconv-gener…
tapico-weyert Apr 9, 2021
8eda347
chore: attempt to correct fix failed merge
tapico-weyert Apr 9, 2021
5b45d5b
fix: remove unwanted `@deprecated`-attribute in semconv template file
tapico-weyert Apr 10, 2021
50ce031
fix: don't fetch the whole otel specification repo
tapico-weyert Apr 10, 2021
628bb71
Merge branch 'main' into chore-otel-add-semconv-generator
weyert Apr 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: run lint:fix-task after generating source files
  • Loading branch information
@tapico-weyert
tapico-weyert committed Apr 8, 2021
commit 3e9f64e94e26f52a424c461e42d5f359291315b1
2 changes: 1 addition & 1 deletion packages/opentelemetry-semantic-conventions/src/resource/ResourceAttribute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

// DO NOT EDIT, this is an Auto-generated file from scripts/semconv/templates//templates/SemanticAttributes.ts.j2
export const ResourceAttributes = {
export const ResourceAttribute = {
/**
* Name of the cloud provider.
*/
Expand Down
7 changes: 6 additions & 1 deletion scripts/semconv/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ docker run --rm \
-f /source code \
--template /templates/SemanticAttributes.ts.j2 \
--output /output/ResourceAttribute.ts \
-Dclass=ResourceAttributes
-Dclass=ResourceAttribute

# Run the automatic linting fixing task to ensure it will pass eslint
cd "$ROOT_DIR/packages/opentelemetry-semantic-conventions"

npm run lint:fix

cd "$ROOT_DIR"