Skip to content

fix: ensure the label names are sanitised #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 8 commits into from
Apr 21, 2021
Merged

fix: ensure the label names are sanitised #2121

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dba2d0b
feat: ensure the label names are sanitised
tapico-weyert Apr 19, 2021
713b62a
chore: make new test prt of the `with SumAggregator`-group
tapico-weyert Apr 19, 2021
c8ebbe2
Merge branch 'main' into fix-attribute-naming
weyert Apr 19, 2021
caa86e9
style: rename sanitize to sanitise in variable name
weyert Apr 19, 2021
cec15b2
chore: run the `lint:fix`-task to fix formatting
tapico-weyert Apr 19, 2021
920c978
style: fixing American spelling continued
weyert Apr 20, 2021
e6c81dc
Fix typo
dyladan Apr 21, 2021
952f86f
Merge branch 'main' into fix-attribute-naming
dyladan Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: rename sanitize to sanitise in variable name 
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
  • Loading branch information
@weyert @obecny
weyert and obecny authored Apr 19, 2021
commit caa86e90822fbd9d2ca67db068e87aa62f200972
2 changes: 1 addition & 1 deletion packages/opentelemetry-exporter-prometheus/src/PrometheusSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function stringify(
let labelsStr = '';

for (const [key, val] of Object.entries(labels)) {
const santisedLabelName = sanitizePrometheusMetricName(key);
const sanitisedLabelName = sanitisePrometheusMetricName(key);
hasLabel = true;
labelsStr += `${
labelsStr.length > 0 ? ',' : ''
Expand Down