chore: url validation & README to prevent gRPC footguns.#2130
Merged
naseemkullah merged 15 commits intoopen-telemetry:mainfrom May 3, 2021
Merged
chore: url validation & README to prevent gRPC footguns.#2130naseemkullah merged 15 commits intoopen-telemetry:mainfrom
naseemkullah merged 15 commits intoopen-telemetry:mainfrom
Conversation
049745c to
8d9d0ef
Compare
8d9d0ef to
93e8fb8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2130 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 140 140
Lines 5002 5002
Branches 1029 1029
=======================================
Hits 4642 4642
Misses 360 360 |
93e8fb8 to
52c810d
Compare
weyert
reviewed
Apr 20, 2021
dyladan
reviewed
Apr 20, 2021
packages/opentelemetry-exporter-collector-grpc/test/CollectorTraceExporter.test.ts
Outdated
Show resolved
Hide resolved
edcb871 to
1b10595
Compare
dyladan
reviewed
Apr 20, 2021
Flarna
reviewed
Apr 21, 2021
Flarna
reviewed
Apr 21, 2021
Flarna
reviewed
Apr 21, 2021
packages/opentelemetry-exporter-collector-grpc/src/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
dyladan
reviewed
Apr 21, 2021
dyladan
reviewed
Apr 30, 2021
dyladan
approved these changes
Apr 30, 2021
obecny
reviewed
Apr 30, 2021
naseemkullah
approved these changes
Apr 30, 2021
vmarchaud
approved these changes
May 1, 2021
Member
Author
|
The thought occurs to me we can do one better than this by reading protocol and if http or https, default to port 80 or 443 respectively, to make things like |
Member
|
From my perspective this looks good to merge but I want to make sure @obecny is ok with that first since he had a comment but hasn't approved yet. |
obecny
approved these changes
May 3, 2021
lizthegrey
added a commit
to honeycombio/opentelemetry-js
that referenced
this pull request
Jul 5, 2021
dyladan
pushed a commit
that referenced
this pull request
Jul 21, 2021
…n host specified without protocol (#2322) * fix regression from #2130 when host specified without protocol * Update util.test.ts * Apply suggestions from code review Co-authored-by: Naseem <naseemkullah@gmail.com> * revert package.json changes * Update util.ts * add tests as per @MSNev request * Update packages/opentelemetry-exporter-collector-grpc/src/util.ts Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: Naseem <naseemkullah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues encountered on an OTel evangelism livestream last week.
Which problem is this PR solving?
/v1/traceor/v1/metricstourlwhen changing from HTTP to gRPC, causing weird DNS errors.Short description of the changes
/in url field.