Skip to content

feat(shim-opentracing): update setTag based on new spec #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmarchaud merged 6 commits into from
Jun 2, 2021
Merged

feat(shim-opentracing): update setTag based on new spec #2194

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89b7c86
feat(shim-opentracing): update setTag based on new spec
vreynolds Apr 21, 2021
b5b31ac
chore(shim-opentracing): address pr comment
vreynolds May 11, 2021
e170434
feat(shim-opentracing): map error tag to status code in addTags
vreynolds May 11, 2021
1e64f3b
chore(shim-opentracing): better function name
vreynolds May 11, 2021
54d2d23
Merge branch 'main' into ot-shim-set-tag
dyladan Jun 1, 2021
3c0ff22
Merge branch 'main' into ot-shim-set-tag
vmarchaud Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(shim-opentracing): better function name
  • Loading branch information
@vreynolds
vreynolds committed May 26, 2021
commit 1e64f3be3419a803a4cabc5eed98ff22be00d271
6 changes: 3 additions & 3 deletions packages/opentelemetry-shim-opentracing/src/shim.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export class SpanShim extends opentracing.Span {
*/
addTags(keyValueMap: SpanAttributes): this {
for (const [key, value] of Object.entries(keyValueMap)) {
if (this._setSpanStatusCode(key, value)) {
if (this._setErrorAsSpanStatusCode(key, value)) {
continue;
}
if (value !== undefined) {
Expand All @@ -317,7 +317,7 @@ export class SpanShim extends opentracing.Span {
* @param value value for the tag
*/
setTag(key: string, value: SpanAttributeValue): this {
if (this._setSpanStatusCode(key, value)) {
if (this._setErrorAsSpanStatusCode(key, value)) {
return this;
}

Expand All @@ -342,7 +342,7 @@ export class SpanShim extends opentracing.Span {
return this._span;
}

private _setSpanStatusCode(
private _setErrorAsSpanStatusCode(
key: string,
value: SpanAttributeValue | undefined
): boolean {
Expand Down