Skip to content

Adding ComponentLogger into instrumentations #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obecny merged 6 commits into from
Jun 9, 2021
Merged

Adding ComponentLogger into instrumentations #2261

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
277e4f7
chore: adding diag component logget to instrumentations
obecny Jun 7, 2021
b073f6b
chore: merge branch 'main' into diag
obecny Jun 7, 2021
1b6b948
Merge branch 'main' into diag
obecny Jun 8, 2021
6133abb
chore: fixing tests
obecny Jun 8, 2021
263748b
Merge branch 'diag' of github.com:obecny/opentelemetry-js into diag
obecny Jun 8, 2021
ee3bccc
chore: fixing tests
obecny Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: merge branch 'main' into diag
  • Loading branch information
@obecny
obecny committed Jun 7, 2021
commit b073f6b7bd9a16e20c868ee0de85fcd94b12470f
4 changes: 2 additions & 2 deletions packages/opentelemetry-instrumentation-http/src/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
this._callResponseHook(span, response);
}

context.bind(response);
context.bind(context.active(), response);
this._diag.debug('outgoingRequest on response()');
response.on('end', () => {
this._diag.debug('outgoingRequest on end()');
Expand Down Expand Up @@ -570,7 +570,7 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
);

instrumentation._diag.debug('%s instrumentation outgoingRequest', component);
context.bind(request, parentContext);
context.bind(parentContext, request);
return instrumentation._traceClientRequest(
component,
request,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.