feat: otlp-grpc exporter uses headers environment variables#2304
Merged
dyladan merged 4 commits intoopen-telemetry:mainfrom Jun 30, 2021
Merged
feat: otlp-grpc exporter uses headers environment variables#2304dyladan merged 4 commits intoopen-telemetry:mainfrom
dyladan merged 4 commits intoopen-telemetry:mainfrom
Conversation
vreynolds
requested review from
Flarna,
MSNev,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2304 +/- ##
=======================================
Coverage 92.74% 92.74%
=======================================
Files 145 145
Lines 5184 5184
Branches 1060 1060
=======================================
Hits 4808 4808
Misses 376 376 |
vmarchaud
reviewed
Jun 29, 2021
packages/opentelemetry-exporter-collector-grpc/src/CollectorMetricExporter.ts
Show resolved
Hide resolved
vmarchaud
reviewed
Jun 29, 2021
packages/opentelemetry-exporter-collector-grpc/src/CollectorTraceExporter.ts
Show resolved
Hide resolved
obecny
reviewed
Jun 29, 2021
packages/opentelemetry-exporter-collector-grpc/src/CollectorMetricExporter.ts
Show resolved
Hide resolved
vmarchaud
approved these changes
Jun 29, 2021
dyladan
approved these changes
Jun 29, 2021
MSNev
reviewed
Jun 29, 2021
packages/opentelemetry-exporter-collector-grpc/src/CollectorExporterNodeBase.ts
Outdated
Show resolved
Hide resolved
MSNev
approved these changes
Jun 29, 2021
obecny
approved these changes
Jun 29, 2021
Merged
This was referenced Feb 22, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes