Skip to content

chore: Fix lint warnings in instrumentation package #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 5 commits into from
Nov 10, 2021
Merged

chore: Fix lint warnings in instrumentation package #2404

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8823214
chore(instrumentation): fix lint warnings
alisabzevari Aug 3, 2021
d9412d8
chore(instrumentation): fix type parameter of InstrumentationModuleFile
alisabzevari Aug 11, 2021
8e0f46c
chore(instrumentation): rename type parameter
alisabzevari Aug 11, 2021
9045870
chore(instrumentation): disable eslint for type cast in parseInstrume…
alisabzevari Sep 2, 2021
bddeafb
chore(instrumentation): fix return type name
alisabzevari Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(instrumentation): fix return type name
  • Loading branch information
@alisabzevari
alisabzevari committed Nov 10, 2021
commit bddeafb5840421dc5113141b0ec738e01ddcb091
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export abstract class InstrumentationBase<T = any>
exports: T,
name: string,
baseDir?: string
): InstrumentationModuleType {
): T {
if (!baseDir) {
if (typeof module.patch === 'function') {
module.moduleExports = exports;
Expand Down