feat: OTEL_EXPORTER_OTLP_ENDPOINT append version and signal#2438
Conversation
…ppend version and signal collector convention of appending the version and signal to the path (e.g. v1/traces or v1/metrics), if not present already
Codecov Report
@@ Coverage Diff @@
## main #2438 +/- ##
=======================================
Coverage 92.70% 92.71%
=======================================
Files 137 137
Lines 4993 4996 +3
Branches 1056 1057 +1
=======================================
+ Hits 4629 4632 +3
Misses 364 364
|
|
Can you please add an explanation to the proper use of the environment variables to the readme? This is likely very confusing to new users already and with this addition it becomes even more cryptic if you don't already know what is going on. |
@dyladan Which section were you thinking of? Quick start, upgrade guidelines, or something else? |
|
As I had more thought, I am basically just following the spec when I was doing this. Were you thinking of a guidance for env var in general that refers to the otel spec? If so, I think that should be a separate PR. |
In the exporter readme, I would add a "configuration" section. |
|
@dyladan I added some documentation to this PR and you can see a preview of that here: https://github.com/open-telemetry/opentelemetry-js/blob/b23f4e8ccf8c92baa93be5e2322fc7f38d929a4d/packages/opentelemetry-exporter-collector/README.md#configuration-options-as-environment-variables |
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
Requesting changes to use only one instance of appendResourcePathToUrlIfNotPresent function inside main exporter collector and then use it whenever you need it.
dyladan
changed the title
|
Changed from fix to feat since this changes behavior |
6 participants
collector convention of appending the version and signal to the path (e.g. v1/traces or v1/metrics), if not present already
resolves #2436