Skip to content

docs(README): Fix links in README.md #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obecny merged 3 commits into from
Sep 9, 2021
Merged

docs(README): Fix links in README.md #2463

obecny merged 3 commits into from
Sep 9, 2021

Conversation

@JamesJHPark
Copy link
Contributor

@JamesJHPark JamesJHPark commented Sep 8, 2021

Which problem is this PR solving?

Short description of the changes

  • This fix is to address the broken links issue in the OpenTelemetry SDK Reference TypeDoc (links to Getting Started, Contributing, Development Guide, Benchmarks, Examples) by replacing the relative URLs with the appropriate absolute URLs in README.md.

@JamesJHPark JamesJHPark requested a review from a team September 8, 2021 21:08
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

dyladan
dyladan approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a good doc fix. Sign the CLA and this will merge quickly

@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #2463 (4a36e59) into main (a1875b6) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
- Coverage   93.22%   93.18%   -0.04%     
==========================================
  Files         137      137              
  Lines        5017     5017              
  Branches     1060     1060              
==========================================
- Hits         4677     4675       -2     
- Misses        340      342       +2
Impacted Files Coverage Δ
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@obecny obecny merged commit 5fefbb2 into open-telemetry:main Sep 9, 2021
@obecny obecny added the document Documentation-related label Sep 9, 2021
@dyladan dyladan mentioned this pull request Sep 13, 2021
Merged
@pragmaticivan pragmaticivan mentioned this pull request Sep 17, 2021
Closed
@dyladan dyladan mentioned this pull request Sep 30, 2021
Merged
@JamesJHPark JamesJHPark mentioned this pull request Nov 3, 2021
Closed
6 tasks
@snyk-bot snyk-bot mentioned this pull request May 26, 2023
Open
This was referenced May 26, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyladan dyladan dyladan approved these changes

+3 more reviewers

@obecny obecny obecny approved these changes

@Flarna Flarna Flarna approved these changes

@MSNev MSNev MSNev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

document Documentation-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JamesJHPark @obecny @dyladan @Flarna @MSNev