Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
32d7962
chore: updating submodule for opentelemetry-proto
Sep 21, 2021
f9972c8
chore: initialized exporter-metrics-otlp-grpc package
Sep 21, 2021
9685772
feat\!: populated exporter-metrics-otlp-grpc package
Sep 21, 2021
007970c
chore: bootstrapped exporter-metrics-otlp-http package
Sep 21, 2021
9618274
feat\!: migrated metric exporter logic to exporter-metrics-otlp-http
Sep 21, 2021
d2ecae0
chore: updating submodule for opentelemetry-proto
Sep 21, 2021
07b43bf
chore: bootstrapped exporter-metrics-otlp-proto package
Sep 21, 2021
5ac7d7b
feat!: migrated proto logic to exporter-metrics-otlp-proto package
Sep 21, 2021
308cfe3
fix: fixed some issues in grpc and proto
Sep 22, 2021
16e7a95
removed debug logging
Sep 22, 2021
c50cada
added api to devdeps
Sep 22, 2021
e5ed763
merge branch 'main' into split-exporters
Sep 29, 2021
0751815
fixed imports
Sep 29, 2021
b886cb9
merge 'main' into split-exporters
Oct 5, 2021
211fa12
updated versions to latest
Oct 5, 2021
9140258
fixed merge conflicts
Oct 26, 2021
8b3571f
applied changes from #2496 to metricHelpers
Oct 26, 2021
752463e
renamed exporter-otlp-http -> exporter-trace-otlp-http
Oct 26, 2021
c4aa74a
renamed exporter-otlp-grpc -> exporter-trace-otlp-grpc
Oct 26, 2021
3e7daf4
renamed exporter-otlp-proto -> exporter-trace-otlp-proto
Oct 26, 2021
44de3a7
Merge branch 'main' into split-exporters
dyladan Oct 26, 2021
8eccf90
Merge branch 'main' into split-exporters
vmarchaud Oct 27, 2021
2992e5c
fix conflicts and bump api version
Oct 28, 2021
81891ec
Merge branch 'split-exporters' of https://github.com/willarmiros/open…
Oct 28, 2021
353d038
Merge branch 'main' into split-exporters
dyladan Nov 1, 2021
e068039
Merge branch 'main' into split-exporters
rauno56 Nov 2, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed merge conflicts
  • Loading branch information
William Armiros committed Oct 26, 2021
commit 91402588ebea87d00059715eebc4e0cc251f1d49
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import {
ensureMetadataIsCorrect,
ensureResourceIsCorrect,
mockCounter,
mockObserver,
mockValueRecorder,
mockObservableGauge,
mockHistogram,
} from './metricsHelper';

const metricsServiceProtoPath =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function toCollectorLabels(
export function toAggregationTemporality(
metric: MetricRecord
): otlpTypes.opentelemetryProto.metrics.v1.AggregationTemporality {
if (metric.descriptor.metricKind === MetricKind.VALUE_OBSERVER) {
if (metric.descriptor.metricKind === MetricKind.OBSERVABLE_GAUGE) {
return otlpTypes.opentelemetryProto.metrics.v1.AggregationTemporality
.AGGREGATION_TEMPORALITY_UNSPECIFIED;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ import {
ensureHistogramIsCorrect,
ensureWebResourceIsCorrect,
mockCounter,
mockObserver,
mockValueRecorder,
mockObservableGauge,
mockHistogram,
} from '../metricsHelper';

describe('OTLPMetricExporter - web', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
import * as assert from 'assert';
import * as sinon from 'sinon';
import { OTLPExporterBase, otlpTypes } from '@opentelemetry/exporter-otlp-http';
import { mockCounter, mockObserver } from '../metricsHelper';
import { mockCounter, mockObservableGauge } from '../metricsHelper';

type CollectorExporterConfig = otlpTypes.OTLPExporterConfigBase;
class OTLPMetricExporter extends OTLPExporterBase<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@

import {
Counter,
ObserverResult,
SumObserver,
UpDownSumObserver,
ValueObserver,
ValueRecorder,
ObservableResult,
ObservableCounter,
ObservableUpDownCounter,
ObservableGauge,
Histogram,
ValueType,
} from '@opentelemetry/api-metrics';
import { InstrumentationLibrary, VERSION } from '@opentelemetry/core';
Expand Down Expand Up @@ -75,16 +75,16 @@ export function mockDoubleCounter(): metrics.Metric<metrics.BoundCounter> &
return metric;
}

export function mockObserver(
callback: (observerResult: ObserverResult) => unknown,
name = 'double-observer'
): metrics.Metric<metrics.BoundObserver> & ValueObserver {
export function mockObservableGauge(
callback: (observableResult: ObservableResult) => unknown,
name = 'double-observable-gauge'
): metrics.Metric<metrics.BoundObservable> & ObservableGauge {
const metric =
meter['_metrics'].get(name) ||
meter.createValueObserver(
meter.createObservableGauge(
name,
{
description: 'sample observer description',
description: 'sample observable gauge description',
valueType: ValueType.DOUBLE,
},
callback
Expand All @@ -94,16 +94,16 @@ export function mockObserver(
return metric;
}

export function mockSumObserver(
callback: (observerResult: ObserverResult) => unknown,
name = 'double-sum-observer'
): metrics.Metric<metrics.BoundObserver> & SumObserver {
export function mockObservableCounter(
callback: (observableResult: ObservableResult) => unknown,
name = 'double-observable-counter'
): metrics.Metric<metrics.BoundObservable> & ObservableCounter {
const metric =
meter['_metrics'].get(name) ||
meter.createSumObserver(
meter.createObservableCounter(
name,
{
description: 'sample sum observer description',
description: 'sample observable counter description',
valueType: ValueType.DOUBLE,
},
callback
Expand All @@ -113,16 +113,16 @@ export function mockSumObserver(
return metric;
}

export function mockUpDownSumObserver(
callback: (observerResult: ObserverResult) => unknown,
name = 'double-up-down-sum-observer'
): metrics.Metric<metrics.BoundObserver> & UpDownSumObserver {
export function mockObservableUpDownCounter(
callback: (observableResult: ObservableResult) => unknown,
name = 'double-up-down-observable-counter'
): metrics.Metric<metrics.BoundObservable> & ObservableUpDownCounter {
const metric =
meter['_metrics'].get(name) ||
meter.createUpDownSumObserver(
meter.createObservableUpDownCounter(
name,
{
description: 'sample up down sum observer description',
description: 'sample observable up down counter description',
valueType: ValueType.DOUBLE,
},
callback
Expand All @@ -132,13 +132,13 @@ export function mockUpDownSumObserver(
return metric;
}

export function mockValueRecorder(): metrics.Metric<metrics.BoundValueRecorder> &
ValueRecorder {
const name = 'int-recorder';
export function mockHistogram(): metrics.Metric<metrics.BoundHistogram> &
Histogram {
const name = 'int-histogram';
const metric =
meter['_metrics'].get(name) ||
meter.createValueRecorder(name, {
description: 'sample recorder description',
meter.createHistogram(name, {
description: 'sample histogram description',
valueType: ValueType.INT,
boundaries: [0, 100],
});
Expand All @@ -164,7 +164,7 @@ export const mockedInstrumentationLibraries: InstrumentationLibrary[] = [
];

export const multiResourceMetricsGet = function (
callback: (observerResult: ObserverResult) => unknown
callback: (observableResult: ObservableResult) => unknown
): any[] {
return [
{
Expand All @@ -173,7 +173,7 @@ export const multiResourceMetricsGet = function (
instrumentationLibrary: mockedInstrumentationLibraries[0],
},
{
...mockObserver(callback),
...mockObservableGauge(callback),
resource: mockedResources[1],
instrumentationLibrary: mockedInstrumentationLibraries[0],
},
Expand All @@ -186,7 +186,7 @@ export const multiResourceMetricsGet = function (
};

export const multiInstrumentationLibraryMetricsGet = function (
callback: (observerResult: ObserverResult) => unknown
callback: (observableResult: ObservableResult) => unknown
): any[] {
return [
{
Expand All @@ -195,7 +195,7 @@ export const multiInstrumentationLibraryMetricsGet = function (
instrumentationLibrary: mockedInstrumentationLibraries[0],
},
{
...mockObserver(callback),
...mockObservableGauge(callback),
resource: mockedResources[0],
instrumentationLibrary: mockedInstrumentationLibraries[1],
},
Expand Down Expand Up @@ -295,15 +295,15 @@ export function ensureDoubleCounterIsCorrect(
});
}

export function ensureObserverIsCorrect(
export function ensureObservableGaugeIsCorrect(
metric: otlpTypes.opentelemetryProto.metrics.v1.Metric,
time: number,
value: number,
name = 'double-observer'
name = 'double-observable-gauge'
) {
assert.deepStrictEqual(metric, {
name,
description: 'sample observer description',
description: 'sample observable gauge description',
unit: '1',
doubleGauge: {
dataPoints: [
Expand All @@ -318,15 +318,15 @@ export function ensureObserverIsCorrect(
});
}

export function ensureSumObserverIsCorrect(
export function ensureObservableCounterIsCorrect(
metric: otlpTypes.opentelemetryProto.metrics.v1.Metric,
time: number,
value: number,
name = 'double-sum-observer'
name = 'double-observable-counter'
) {
assert.deepStrictEqual(metric, {
name,
description: 'sample sum observer description',
description: 'sample observable counter description',
unit: '1',
doubleSum: {
isMonotonic: true,
Expand All @@ -345,15 +345,15 @@ export function ensureSumObserverIsCorrect(
});
}

export function ensureUpDownSumObserverIsCorrect(
export function ensureObservableUpDownCounterIsCorrect(
metric: otlpTypes.opentelemetryProto.metrics.v1.Metric,
time: number,
value: number,
name = 'double-up-down-sum-observer'
name = 'double-up-down-observable-counter'
) {
assert.deepStrictEqual(metric, {
name,
description: 'sample up down sum observer description',
description: 'sample observable up down counter description',
unit: '1',
doubleSum: {
isMonotonic: false,
Expand All @@ -372,15 +372,15 @@ export function ensureUpDownSumObserverIsCorrect(
});
}

export function ensureValueRecorderIsCorrect(
export function ensureHistogramIsCorrect(
metric: otlpTypes.opentelemetryProto.metrics.v1.Metric,
time: number,
explicitBounds: (number | null)[] = [Infinity],
bucketCounts: number[] = [2, 0]
) {
assert.deepStrictEqual(metric, {
name: 'int-recorder',
description: 'sample recorder description',
name: 'int-histogram',
description: 'sample histogram description',
unit: '1',
intHistogram: {
dataPoints: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ import {
ensureObservableGaugeIsCorrect,
ensureHistogramIsCorrect,
mockCounter,
mockObserver,
mockValueRecorder,
mockObservableGauge,
mockHistogram,
} from '../metricsHelper';
import { MockedResponse } from './nodeHelpers';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ import {
ensureExportMetricsServiceRequestIsSet,
mockCounter,
MockedResponse,
mockObserver,
mockValueRecorder,
mockObservableGauge,
mockHistogram,
} from './metricsHelper';

const fakeRequest = {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.