fix: remove usage of serviceName property in tests for otel collector#2491
Merged
vmarchaud merged 1 commit intoopen-telemetry:mainfrom Sep 25, 2021
Merged
Conversation
|
|
Flarna
approved these changes
Sep 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #2491 +/- ##
==========================================
- Coverage 93.22% 93.20% -0.02%
==========================================
Files 137 137
Lines 5017 5017
Branches 1060 1060
==========================================
- Hits 4677 4676 -1
- Misses 340 341 +1
|
Member
|
Please sign the CLA |
dyladan
approved these changes
Sep 22, 2021
obecny
approved these changes
Sep 24, 2021
vmarchaud
approved these changes
Sep 25, 2021
6 tasks
This was referenced May 26, 2023
[Snyk] Upgrade @opentelemetry/exporter-jaeger from 0.25.0 to 0.26.0
0xETHengineer/opentelemetry-js#2
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
serviceName#2278serviceNameproperty from tests in opentelemetry-exporter-otlp-http packageShort description of the changes
serviceNameproperty for configuration of OTLPTraceExporter and OTPLMetricExporter.serviceNameis not a valid property of the config object (OTLPExporterNodeConfigBase), this PR removes the usage of this property in the test cases.